-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use busybox from quay.io #152
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tests/integration/ray_test.go
Outdated
@@ -319,7 +319,7 @@ func createRayCluster(test support.Test, namespace string, mnist *corev1.ConfigM | |||
InitContainers: []corev1.Container{ | |||
{ | |||
Name: "init-myservice", | |||
Image: "busybox:1.28", | |||
Image: "quay.io/project-codeflare/busybox:1.28", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we're using 1.28
and not 1.36
which appears to be the latest one we've got in quay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimakis Yes, true you are right. Updated to 1.36.
af143fc
to
43cdf50
Compare
@jiripetrlik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Replaced by #153 |
Use busybox from quay.io instead of from Docker hub. Version should stay the same.